PMD Results

The following document contains the results of PMD 4.2.5.

Files

net/sourceforge/jeuclid/app/mathviewer/FileIO.java

ViolationLine
Avoid instantiation through private constructors from outside of the constructor's class.59
Avoid if (x != y) ..; else ..;114 - 118
Avoid if (x != y) ..; else ..;197 - 201
Avoid if (x != y) ..; else ..;238 - 260

net/sourceforge/jeuclid/app/mathviewer/FontSelectionDialog.java

ViolationLine
Use ArrayList instead of Vector125

net/sourceforge/jeuclid/app/mathviewer/InsertPolynomDialog.java

ViolationLine
Avoid really long methods.43 - 158
Avoid unused method parameters such as 'evt'.160 - 164
Avoid unused method parameters such as 'evt'.170 - 174
Prefer StringBuffer over += for concatenating strings182
Avoid if (x != y) ..; else ..;185 - 190
Prefer StringBuffer over += for concatenating strings186
Prefer StringBuffer over += for concatenating strings189
Prefer StringBuffer over += for concatenating strings191
Perhaps 'degreeLabel' could be replaced by a local variable.220
Perhaps 'okButton' could be replaced by a local variable.222

net/sourceforge/jeuclid/app/mathviewer/InsertTableDialog.java

ViolationLine
Avoid really long methods.40 - 236
Avoid unused method parameters such as 'evt'.238 - 242
Avoid unused method parameters such as 'evt'.248 - 252
Prefer StringBuffer over += for concatenating strings262
Prefer StringBuffer over += for concatenating strings264
Prefer StringBuffer over += for concatenating strings268
Prefer StringBuffer over += for concatenating strings271
Perhaps 'buttonGroupType' could be replaced by a local variable.313
Perhaps 'cancelButton' could be replaced by a local variable.314
Perhaps 'columnsLabel' could be replaced by a local variable.315
Perhaps 'okButton' could be replaced by a local variable.319
Perhaps 'rowsLabel' could be replaced by a local variable.320
Perhaps 'typeLabel' could be replaced by a local variable.323

net/sourceforge/jeuclid/app/mathviewer/MainFrame.java

ViolationLine
This class has too many methods, consider refactoring it.71 - 1206
Avoid really long classes.71 - 1206
Too many fields71 - 1206
Overridable method 'getJJMenuBar' called during object construction185
Avoid empty catch blocks615 - 617
Avoid empty catch blocks628 - 630
Prefer StringBuffer over += for concatenating strings1202

net/sourceforge/jeuclid/app/mathviewer/MathViewer.java

ViolationLine
The class 'MathViewer' has a Cyclomatic Complexity of 6 (Highest = 10).40 - 110
The method 'main' has a Cyclomatic Complexity of 10.70 - 109

net/sourceforge/jeuclid/app/mathviewer/ParametersDialog.java

ViolationLine
This class has too many methods, consider refactoring it.62 - 282
The class 'ParametersDialog' has a Cyclomatic Complexity of 4 (Highest = 10).62 - 282
Avoid instantiating new objects inside loops111
The method 'createInputForParameter' has a Cyclomatic Complexity of 10.159 - 214

net/sourceforge/jeuclid/biparser/BiNode.java

ViolationLine
The class 'BiNode' has a Cyclomatic Complexity of 4 (Highest = 10).32 - 506
The method 'insert' has a Cyclomatic Complexity of 10.143 - 185

net/sourceforge/jeuclid/biparser/BiTree.java

ViolationLine
Document empty constructor46 - 48

net/sourceforge/jeuclid/biparser/JEuclidSAXHandler.java

ViolationLine
StringBuffers can grow quite a lot, and so may become a source of memory leak (if the owning class has a long life time).47

net/sourceforge/jeuclid/biparser/ReparseException.java

ViolationLine
Document empty constructor31 - 33

net/sourceforge/jeuclid/biparser/SAXBiParser.java

ViolationLine
Avoid instantiation through private constructors from outside of the constructor's class.48

net/sourceforge/jeuclid/biparser/TextNode.java

ViolationLine
This final field could be made static40